Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user resource methods #327

Merged
merged 3 commits into from
Sep 6, 2024
Merged

feat: add user resource methods #327

merged 3 commits into from
Sep 6, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Sep 5, 2024

Adding support for getting and updating the current user as well as other users for admins.

@ecrupper ecrupper requested a review from a team as a code owner September 5, 2024 18:33
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (5c3dd6d) to head (6747584).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   89.38%   89.63%   +0.25%     
==========================================
  Files          21       22       +1     
  Lines         857      878      +21     
==========================================
+ Hits          766      787      +21     
  Misses         55       55              
  Partials       36       36              
Files with missing lines Coverage Δ
vela/client.go 91.13% <100.00%> (+0.04%) ⬆️
vela/user.go 100.00% <100.00%> (ø)

wass3r
wass3r previously approved these changes Sep 6, 2024
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 747bf8d into main Sep 6, 2024
9 of 11 checks passed
@ecrupper ecrupper deleted the feat/user-management branch September 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants